Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add script to update the database for adding more documents #287

Merged
merged 1 commit into from
May 20, 2023

Conversation

maozdemir
Copy link
Contributor

@maozdemir maozdemir commented May 18, 2023

Move environment variables to the global scope
Add a better check for vectorstore existence
Introduced a new function for better readability
Co-authored-by: Pulp 51127079+PulpCattel@users.noreply.github.com

Recreating the PR #201 due to the history getting way too messy (my frustration was beyond imagination...). Sorry for the inconvenience.

Move environment variables to the global scope
Add a better check for vectorstore existence
Introduced a new function for better readability
Co-authored-by: Pulp <51127079+PulpCattel@users.noreply.github.com>
@PulpCattel
Copy link

Tested and works. IMHO the does_vectorstore_exist function implementation is too fragile/hardcoded. I think even just checking if persist_directory is empty or not may be enough and much cleaner, but I'm not sure.

Thank you for working on this!

Copy link
Collaborator

@imartinez imartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments. The solution looks great to me. Thanks a lot for this contribution!

ingest.py Show resolved Hide resolved
ingest.py Show resolved Hide resolved
ingest.py Show resolved Hide resolved
@imartinez imartinez merged commit 7180d43 into zylon-ai:main May 20, 2023
@imartinez
Copy link
Collaborator

@PulpCattel @maozdemir I updated the branch with main, applied the comments and merged it to main.

@maozdemir maozdemir changed the title Add script to update the database for adding more documents feat: Add script to update the database for adding more documents May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants